Skip to content

[Serve] Make Deployment handle serializable#22473

Merged
simon-mo merged 1 commit intoray-project:masterfrom
architkulkarni:fix-handle-serializable
Feb 18, 2022
Merged

[Serve] Make Deployment handle serializable#22473
simon-mo merged 1 commit intoray-project:masterfrom
architkulkarni:fix-handle-serializable

Conversation

@architkulkarni
Copy link
Copy Markdown
Contributor

Why are these changes needed?

Fixes an unpicklable lambda error that prevented handles from being passed into Serve deployment constructors. The idea for the fix is from @simon-mo.

Related issue number

Closes #22110

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo merged commit df85d31 into ray-project:master Feb 18, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cant pickle RayServeSyncHandle from Ray1.9

2 participants