Skip to content

[RLlib] Disable A3C CI tests on torch for now#22426

Merged
sven1977 merged 1 commit intoray-project:masterfrom
gjoliver:a3c-test
Feb 16, 2022
Merged

[RLlib] Disable A3C CI tests on torch for now#22426
sven1977 merged 1 commit intoray-project:masterfrom
gjoliver:a3c-test

Conversation

@gjoliver
Copy link
Copy Markdown
Member

Why are these changes needed?

Disable A3C test on torch for now due to a race condition during worker initialization.
Also extend performance_test deadline to 3hrs.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • [*] Release tests
    • This PR is not tested :(

@gjoliver gjoliver requested a review from sven1977 February 16, 2022 10:06
Copy link
Copy Markdown
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the quick workaround.

@sven1977 sven1977 merged commit 04dd536 into ray-project:master Feb 16, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants