Skip to content

[RLlib] Add A3C to rllib perf regression tests.#22316

Merged
sven1977 merged 2 commits intoray-project:masterfrom
gjoliver:a3c-perf
Feb 11, 2022
Merged

[RLlib] Add A3C to rllib perf regression tests.#22316
sven1977 merged 2 commits intoray-project:masterfrom
gjoliver:a3c-perf

Conversation

@gjoliver
Copy link
Copy Markdown
Member

Why are these changes needed?

Auto perf-regression A3C

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • [*] Release tests
    • This PR is not tested :(

@gjoliver gjoliver requested a review from sven1977 February 11, 2022 17:51
@gjoliver
Copy link
Copy Markdown
Member Author

I am intentionally running exec_plan first for a few days, so we can hopefully see the diff when we turn this off.

@sven1977 sven1977 self-assigned this Feb 11, 2022
[32, [3, 3], 2],
[32, [3, 3], 2],
]
# TODO(jungong) : flip to True after we have collected some data.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's not forget about this :)

Copy link
Copy Markdown
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @gjoliver ! :)

@sven1977 sven1977 merged commit cbd2450 into ray-project:master Feb 11, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants