[serve] Improve health check failure semantics#22297
Merged
edoakes merged 35 commits intoray-project:masterfrom Feb 14, 2022
Merged
[serve] Improve health check failure semantics#22297edoakes merged 35 commits intoray-project:masterfrom
edoakes merged 35 commits intoray-project:masterfrom
Conversation
…e-health-check
…e-health-check
…e-health-check
938cd48 to
6949a45
Compare
92ed219 to
15927ae
Compare
…e-consecutive-health-check
Collaborator
Author
|
@shrekris-anyscale @simon-mo ready for review |
shrekris-anyscale
approved these changes
Feb 11, 2022
Contributor
shrekris-anyscale
left a comment
There was a problem hiding this comment.
Nice job! I added a couple notes about some of the comments. Once those are addressed, this should be good to go.
Collaborator
Author
|
@shrekris-anyscale I updated the docstrings and am using |
Contributor
|
@edoakes I like the enum changes. I added a couple comments about them. |
simon-mo
approved these changes
Feb 14, 2022
architkulkarni
added a commit
that referenced
this pull request
Feb 23, 2022
This reverts commit 610930a.
This was referenced Feb 23, 2022
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Follow-up from #22297
Enhances the health check failure detection logic.
UNHEALTHY.TODO:
Related issue number
Checks
scripts/format.shto lint the changes in this PR.