Fix a bug from many drivers.#22248
Merged
rkooo567 merged 1 commit intoray-project:masterfrom Feb 9, 2022
Merged
Conversation
ericl
approved these changes
Feb 9, 2022
Contributor
ericl
left a comment
There was a problem hiding this comment.
Should we just default to utf-8 always?
Contributor
Author
|
Hmm actually a good question. Let me try changing the default and see if it breaks any test. |
Contributor
Author
|
I will merge it first since there's the fire (broken test). Will create one more PR |
6 tasks
ericl
pushed a commit
that referenced
this pull request
Feb 15, 2022
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
After this PR (ray-project#22156), for some reasons the driver script has some string that cannot be encoded with ascii. It seems like using utf-8 solves the problem.
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
After this PR (#22156), for some reasons the driver script has some string that cannot be encoded with ascii. It seems like using utf-8 solves the problem.
Related issue number
Closes #22238
Checks
scripts/format.shto lint the changes in this PR.