Skip to content

[e2e] Update e2e test to use redisless ray by default.#22189

Merged
fishbone merged 1 commit intoray-project:masterfrom
fishbone:test-redisless-ray-e2e
Feb 9, 2022
Merged

[e2e] Update e2e test to use redisless ray by default.#22189
fishbone merged 1 commit intoray-project:masterfrom
fishbone:test-redisless-ray-e2e

Conversation

@fishbone
Copy link
Copy Markdown
Contributor

@fishbone fishbone commented Feb 7, 2022

Why are these changes needed?

As title, after infra got updated, we need to merge the PR so that test can run ray without redis.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fishbone fishbone added the do-not-merge Do not merge this PR! label Feb 7, 2022
@fishbone
Copy link
Copy Markdown
Contributor Author

fishbone commented Feb 7, 2022

It should be merged after infra got updated.

@DmitriGekhtman
Copy link
Copy Markdown
Contributor

Looks good. Just confirming: do these tests use an anyscale/ray:nightly base image?

@fishbone
Copy link
Copy Markdown
Contributor Author

fishbone commented Feb 9, 2022

base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray-ml:nightly-py37-gpu"
base_image: "anyscale/ray-ml:nightly-py37-gpu"
base_image: "anyscale/ray:nightly-py37-cu102"
base_image: "anyscale/ray-ml:nightly-py37-gpu"
base_image: "anyscale/ray-ml:nightly-py37-gpu"
base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray:nightly-py37"
base_image: "anyscale/ray:nightly-py37"

Seems so.
I'll merge this since I verified it's working. (https://console.anyscale.com/o/anyscale-internal/projects/prj_LFKjNprpiYt4AjAf1NdLDJwn/clusters/ses_sMEF5HBXvkX4C26fCRCr4Yga?command-history-section=event_log)

@fishbone fishbone merged commit d8ac01b into ray-project:master Feb 9, 2022
@fishbone fishbone removed the do-not-merge Do not merge this PR! label Feb 9, 2022
mwtian pushed a commit to mwtian/ray that referenced this pull request Feb 15, 2022
…2189)

As title, after infra got updated, we need to merge the PR so that test can run ray without redis.
mwtian added a commit that referenced this pull request Feb 15, 2022
* [e2e] Update e2e test to use redisless ray by default. (#22189)

As title, after infra got updated, we need to merge the PR so that test can run ray without redis.

* [e2e] Fix an error when "env_vars" is not set. (#22234)

To fix error in session https://buildkite.com/ray-project/periodic-ci/builds/2699#c532ed2b-ee89-48ad-a7db-fd4211ef8bd9

Co-authored-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
…2189)

As title, after infra got updated, we need to merge the PR so that test can run ray without redis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants