Fix nightly shuffle_data_loader by pinning down dependencies versions#22183
Merged
scv119 merged 1 commit intoray-project:masterfrom Feb 7, 2022
Merged
Fix nightly shuffle_data_loader by pinning down dependencies versions#22183scv119 merged 1 commit intoray-project:masterfrom
scv119 merged 1 commit intoray-project:masterfrom
Conversation
Contributor
Author
Contributor
|
@clarkzinzow @ericl we should consider deprecate this shuffle loader once dataset is GA. |
scv119
approved these changes
Feb 7, 2022
Contributor
|
@scv119 AFAIK no one is using it, and it never made it out of alpha, so we could deprecate it now or whenever is convenient. |
Contributor
Author
|
@scv119 Are you fine with me removing it now. We should remove it if it's not used to reduce maintenance overhead. |
Contributor
|
If nobody is using it, let's remove it! |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See fsspec/s3fs#588
Related issue number
Closes #22162
Checks
scripts/format.shto lint the changes in this PR.