Skip to content

fix "team:xxx" tag of cpp tests#22163

Merged
scv119 merged 1 commit intoray-project:masterfrom
antgroup:dev_cpp
Feb 7, 2022
Merged

fix "team:xxx" tag of cpp tests#22163
scv119 merged 1 commit intoray-project:masterfrom
antgroup:dev_cpp

Conversation

@SongGuyang
Copy link
Copy Markdown
Contributor

Why are these changes needed?

Cpp worker tests should be part of ray core.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@SongGuyang SongGuyang requested a review from simon-mo February 7, 2022 07:10
@simon-mo simon-mo removed their request for review February 7, 2022 07:27
@simon-mo
Copy link
Copy Markdown
Contributor

simon-mo commented Feb 7, 2022

Thanks @SongGuyang for filing this. I have re-assigned @ericl @scv119 to acknowledge this. The historical context was that the original assignment was for the internal team (@AmeerHajAli) that have shepherd the PR.

@scv119 scv119 merged commit 8e1e783 into ray-project:master Feb 7, 2022
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
Cpp worker tests should be part of ray core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants