Revert "[Release 1.11.0][Core] avoid unnecessary work during event st…#22144
Merged
rkooo567 merged 1 commit intoray-project:masterfrom Feb 7, 2022
Merged
Conversation
…ats collection (ray-project#22054)" This reverts commit 9ac3f68.
mwtian
approved these changes
Feb 7, 2022
Contributor
Author
|
cc @mwtian I merged it. Let's see next 10~ish build results and see if things are fixed by this. |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
ray-project#22144) This reverts commit 9ac3f68. Seems like this makes this test flaky, so I will revert it for now.
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Feb 27, 2022
…event st… (ray-project#22144)" (ray-project#22284) This reverts commit 6235b6d. Looks like windows://python/ray/tests:test_dataclient_disconnect has similar level of flakiness as before the revert. This seems unrelated and the test needs to be fixed in another way.
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Mar 8, 2022
ray-project#22144) This reverts commit 9ac3f68. Seems like this makes this test flaky, so I will revert it for now.
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Mar 8, 2022
…event st… (ray-project#22144)" (ray-project#22284) This reverts commit 6235b6d. Looks like windows://python/ray/tests:test_dataclient_disconnect has similar level of flakiness as before the revert. This seems unrelated and the test needs to be fixed in another way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ats collection (#22054)"
This reverts commit 9ac3f68.
Seems like this makes this test flaky, so I will revert it for now.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.