Skip to content

Revert "[RLlib] AlphaStar: Parallelized, multi-agent/multi-GPU learni…#22105

Merged
rkooo567 merged 1 commit intoray-project:masterfrom
rkooo567:revert-rllib-failure
Feb 4, 2022
Merged

Revert "[RLlib] AlphaStar: Parallelized, multi-agent/multi-GPU learni…#22105
rkooo567 merged 1 commit intoray-project:masterfrom
rkooo567:revert-rllib-failure

Conversation

@rkooo567
Copy link
Copy Markdown
Contributor

@rkooo567 rkooo567 commented Feb 4, 2022

…ng via league-based self-play. (#21356)"

This reverts commit 3f03ef8.

Why are these changes needed?

Screen Shot 2022-02-03 at 10 49 55 PM

Not sure how, but this PR seems to start breaking many tests. cc @sven1977

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Copy Markdown
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty weird. all the rllib tests are actually passing.

@rkooo567
Copy link
Copy Markdown
Contributor Author

rkooo567 commented Feb 4, 2022

@gjoliver



runpy.run_path(name)
--
  | File "/opt/miniconda/lib/python3.6/runpy.py", line 263, in run_path
  | pkg_name=pkg_name, script_name=fname)
  | File "/opt/miniconda/lib/python3.6/runpy.py", line 96, in _run_module_code
  | mod_name, mod_spec, pkg_name, script_name)
  | File "/opt/miniconda/lib/python3.6/runpy.py", line 85, in _run_code
  | exec(code, run_globals)
  | File "/tmp/tmpa7hc7kq2", line 39, in <module>
  | import ray.rllib.agents.ppo as ppo
  | File "/ray/python/ray/rllib/__init__.py", line 58, in <module>
  | _register_all()
  | File "/ray/python/ray/rllib/__init__.py", line 39, in _register_all
  | register_trainable(key, get_trainer_class(key))
  | File "/ray/python/ray/rllib/agents/registry.py", line 220, in get_trainer_class
  | return _get_trainer_class(alg, return_config=return_config)
  | File "/ray/python/ray/rllib/agents/registry.py", line 238, in _get_trainer_class
  | class_, config = ALGORITHMS[alg]()
  | File "/ray/python/ray/rllib/agents/registry.py", line 22, in _import_alpha_star
  | from ray.rllib.agents import alpha_star
  | File "/ray/python/ray/rllib/agents/alpha_star/__init__.py", line 1, in <module>
  | from ray.rllib.agents.alpha_star.alpha_star import DEFAULT_CONFIG, AlphaStarTrainer
  | File "/ray/python/ray/rllib/agents/alpha_star/alpha_star.py", line 14, in <module>
  | import ray.rllib.agents.ppo.appo as appo
  | AttributeError: module 'ray' has no attribute 'rllib'

This seems to be a failure msg

@rkooo567 rkooo567 merged commit a887763 into ray-project:master Feb 4, 2022
sven1977 added a commit that referenced this pull request Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants