Skip to content

[core] Enable lineage reconstruction in CI#21519

Merged
stephanie-wang merged 5 commits intoray-project:masterfrom
stephanie-wang:enable-lineage-reconstruction
Feb 18, 2022
Merged

[core] Enable lineage reconstruction in CI#21519
stephanie-wang merged 5 commits intoray-project:masterfrom
stephanie-wang:enable-lineage-reconstruction

Conversation

@stephanie-wang
Copy link
Copy Markdown
Contributor

@stephanie-wang stephanie-wang commented Jan 11, 2022

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@stephanie-wang stephanie-wang added the do-not-merge Do not merge this PR! label Jan 11, 2022
@stephanie-wang stephanie-wang force-pushed the enable-lineage-reconstruction branch from 0ab80de to 6f5f2ae Compare January 12, 2022 01:43
@frank-lsf frank-lsf mentioned this pull request Jan 21, 2022
Closed
@bveeramani
Copy link
Copy Markdown
Member

bveeramani commented Jan 30, 2022

‼️ ACTION REQUIRED ‼️

We've switched our code formatter from YAPF to Black (see #21311).

To prevent issues with merging your code, here's what you'll need to do:

  1. Install Black
pip install -I black==21.12b0
  1. Format changed files with Black
curl -o format-changed.sh https://gist.githubusercontent.com/bveeramani/42ef0e9e387b755a8a735b084af976f2/raw/7631276790765d555c423b8db2b679fd957b984a/format-changed.sh
chmod +x ./format-changed.sh
./format-changed.sh
rm format-changed.sh
  1. Commit your changes.
git add --all
git commit -m "Format Python code with Black"
  1. Merge master into your branch.
git pull upstream master
  1. Resolve merge conflicts (if necessary).

After running these steps, you'll have the updated format.sh.

@stephanie-wang stephanie-wang force-pushed the enable-lineage-reconstruction branch from 4a6ec1b to 7ff0cb4 Compare February 10, 2022 06:56
@stephanie-wang stephanie-wang changed the title [DONOTMERGE][core] Enable lineage reconstruction [core] Enable lineage reconstruction Feb 16, 2022
@stephanie-wang stephanie-wang removed the do-not-merge Do not merge this PR! label Feb 16, 2022
rkooo567
rkooo567 reviewed Feb 17, 2022
View reviewed changes
release/e2e.py Outdated
"TEST_OUTPUT_JSON": results_json,
"TEST_STATE_JSON": state_json,
"IS_SMOKE_TEST": "1" if smoke_test else "0",
"RAY_lineage_pinning_enabled": "1",
Copy link
Copy Markdown
Contributor

@rkooo567 rkooo567 Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this part to a separate field and use update?

    custom_env_vars = {
         "RAY_lineage_pinning_enabled": "1",
    }
    env_vars = {
        "RAY_ADDRESS": os.environ.get("RAY_ADDRESS", "auto"),
        "TEST_OUTPUT_JSON": results_json,
        "TEST_STATE_JSON": state_json,
        "IS_SMOKE_TEST": "1" if smoke_test else "0",
    }

    env_vars.update(custom_env_vars)

So that we can organize this better.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 17, 2022
@ericl ericl changed the title [core] Enable lineage reconstruction [core] Enable lineage reconstruction in CI Feb 17, 2022
@stephanie-wang stephanie-wang merged commit 03a5589 into ray-project:master Feb 18, 2022
@stephanie-wang stephanie-wang deleted the enable-lineage-reconstruction branch February 18, 2022 19:04
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Feb 27, 2022
@stephanie-wang @simonsays1980
[core] Enable lineage reconstruction in CI (ray-project#21519)
0beb41b 
Enables lineage reconstruction in all CI and release tests.
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Mar 8, 2022
@stephanie-wang @simonsays1980
[core] Enable lineage reconstruction in CI (ray-project#21519)
6e8417f 
Enables lineage reconstruction in all CI and release tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@ericl ericl ericl approved these changes

@AmeerHajAli AmeerHajAli Awaiting requested review from AmeerHajAli

@pcmoritz pcmoritz Awaiting requested review from pcmoritz

@raulchen raulchen Awaiting requested review from raulchen

@robertnishihara robertnishihara Awaiting requested review from robertnishihara

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@fishbone fishbone Awaiting requested review from fishbone

Assignees

No one assigned

Labels

@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephanie-wang @bveeramani @ericl @rkooo567