[xray] Corrects Error Handling During Push and Pull.#2059
Merged
pcmoritz merged 3 commits intoray-project:masterfrom May 18, 2018
Merged
[xray] Corrects Error Handling During Push and Pull.#2059pcmoritz merged 3 commits intoray-project:masterfrom
pcmoritz merged 3 commits intoray-project:masterfrom
Conversation
Makes a bad status during Push fatal.
|
Test FAILed. |
pcmoritz
reviewed
May 16, 2018
| } | ||
| } else { | ||
| RAY_LOG(ERROR) << "Buffer Create Failed: " << chunk_status.second.message(); | ||
| RAY_LOG(ERROR) << "Create Chunk Failed index=" << chunk_index << ": " |
Contributor
There was a problem hiding this comment.
Let's do "Create Chunk Failed index = " here, it's slightly prettier :)
|
Test PASSed. |
| RAY_CHECK_OK(PullSendRequest(object_id, async_conn)); | ||
| Status pull_send_status = PullSendRequest(object_id, async_conn); | ||
| if (!pull_send_status.ok()) { | ||
| RAY_LOG(ERROR) << pull_send_status.message(); |
Contributor
There was a problem hiding this comment.
Why log the error here, but not after the call to PullSendRequest below?
Contributor
Author
There was a problem hiding this comment.
Will make this a hard fail.
| return status; | ||
| } | ||
| // Currently, acquiring a connection should not fail. | ||
| RAY_CHECK_OK(status); |
Contributor
There was a problem hiding this comment.
Why should this not fail?
Contributor
Author
There was a problem hiding this comment.
Will add a note about why this should not fail.
|
Test PASSed. |
stephanie-wang
approved these changes
May 18, 2018
Contributor
stephanie-wang
left a comment
There was a problem hiding this comment.
Approved, but at some point we should go over all of the object manager components and determine which should really return a ray::Status.
alok
added a commit
to alok/ray
that referenced
this pull request
May 18, 2018
* master: (22 commits) [xray] Fix bug in updating actor execution dependencies (ray-project#2064) [DataFrame] Refactor __delitem__ (ray-project#2080) [xray] Better error messaging when pulling from self. (ray-project#2068) Use source code in hash where possible (fix ray-project#2089) (ray-project#2090) Functions for flushing done tasks and evicted objects. (ray-project#2033) Fix compilation error for RAY_USE_NEW_GCS with latest clang. (ray-project#2086) [xray] Corrects Error Handling During Push and Pull. (ray-project#2059) [xray] Sophisticated task dependency management (ray-project#2035) Support calling positional arguments by keyword (fix ray-project#998) (ray-project#2081) [DataFrame] Improve performance of iteration methods (ray-project#2026) [DataFrame] Implement to_csv (ray-project#2014) [xray] Lineage cache only requests notifications about remote parent tasks (ray-project#2066) [rllib] Add magic methods for rollouts (ray-project#2024) [DataFrame] Allows DataFrame constructor to take in another DataFrame (ray-project#2072) Pin Pandas version for Travis to 0.22 (ray-project#2075) Fix python linting (ray-project#2076) [xray] Fix GCS table prefixes (ray-project#2065) Some tests for _submit API. (ray-project#2062) [rllib] Queue lib for python 2.7 (ray-project#2057) [autoscaler] Remove faulty assert that breaks during downscaling, pull configs from env (ray-project#2006) ...
alok
added a commit
to alok/ray
that referenced
this pull request
May 21, 2018
* master: (24 commits) Performance fix (ray-project#2110) Use flake8-comprehensions (ray-project#1976) Improve error message printing and suppression. (ray-project#2104) [rllib] [doc] Broken link in ddpg doc YAPF, take 3 (ray-project#2098) [rllib] rename async -> _async (ray-project#2097) fix unused lambda capture (ray-project#2102) [xray] Use pubsub instead of timeout for ObjectManager Pull. (ray-project#2079) [DataFrame] Update _inherit_docstrings (ray-project#2085) [JavaWorker] Changes to the build system for support java worker (ray-project#2092) [xray] Fix bug in updating actor execution dependencies (ray-project#2064) [DataFrame] Refactor __delitem__ (ray-project#2080) [xray] Better error messaging when pulling from self. (ray-project#2068) Use source code in hash where possible (fix ray-project#2089) (ray-project#2090) Functions for flushing done tasks and evicted objects. (ray-project#2033) Fix compilation error for RAY_USE_NEW_GCS with latest clang. (ray-project#2086) [xray] Corrects Error Handling During Push and Pull. (ray-project#2059) [xray] Sophisticated task dependency management (ray-project#2035) Support calling positional arguments by keyword (fix ray-project#998) (ray-project#2081) [DataFrame] Improve performance of iteration methods (ray-project#2026) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects error handling in the ObjectManager.
Pullare fatal.Pushso that aPusheither fails or returns after releasing references to objects and client connections.