Skip to content

[tune] Polishing docs#1846

Merged
richardliaw merged 9 commits intoray-project:masterfrom
richardliaw:tune-docs-v2
Apr 17, 2018
Merged

[tune] Polishing docs#1846
richardliaw merged 9 commits intoray-project:masterfrom
richardliaw:tune-docs-v2

Conversation

@richardliaw
Copy link
Copy Markdown
Contributor

@richardliaw richardliaw commented Apr 7, 2018 •
edited
Loading

Getting feedback from various people to improve docs.

cc: @apengwin

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 7, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4710/
Test FAILed.

ericl
ericl reviewed Apr 8, 2018
View reviewed changes
doc/source/tune.rst Outdated
:emphasize-lines: 1,5

def my_func(config, reporter): # add the reporter parameter
import time, numpy as np
Copy link
Copy Markdown
Contributor

@ericl ericl Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use np?

@richardliaw richardliaw changed the title [tune] (wip) Polishing docs [tune] Polishing docs Apr 15, 2018
robertnishihara
robertnishihara reviewed Apr 15, 2018
View reviewed changes
python/ray/tune/examples/README.md
@@ -0,0 +1,3 @@
# Ray Tune Examples
Copy link
Copy Markdown
Collaborator

@robertnishihara robertnishihara Apr 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight preference for rst here, but not a big deal.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 15, 2018

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4909/
Test FAILed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 15, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4910/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 15, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4913/
Test PASSed.

@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 15, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4916/
Test PASSed.

@richardliaw richardliaw assigned richardliaw and ericl and unassigned richardliaw Apr 17, 2018
@AmplabJenkins
Copy link
Copy Markdown

AmplabJenkins commented Apr 17, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/4960/
Test PASSed.

@richardliaw
Copy link
Copy Markdown
Contributor Author

richardliaw commented Apr 17, 2018

test failures unrelated

@richardliaw richardliaw merged commit f833e4d into ray-project:master Apr 17, 2018
@richardliaw richardliaw deleted the tune-docs-v2 branch April 17, 2018 16:57
royf added a commit to royf/ray that referenced this pull request Apr 22, 2018
@royf
Merge branch 'master' into softq
eb2b27e 
* master:
  Handle interrupts correctly for ASIO synchronous reads and writes. (ray-project#1929)
  [DataFrame] Adding read methods and tests (ray-project#1712)
  Allow task_table_update to fail when tasks are finished. (ray-project#1927)
  [rllib] Contribute DDPG to RLlib (ray-project#1877)
  [xray] Workers blocked in a `ray.get` release their resources (ray-project#1920)
  Raylet task dispatch and throttling worker startup (ray-project#1912)
  [DataFrame] Eval fix (ray-project#1903)
  [tune] Polishing docs (ray-project#1846)
  [tune] [rllib] Automatically determine RLlib resources and add queueing mechanism for autoscaling (ray-project#1848)
  Preemptively push local arguments for actor tasks (ray-project#1901)
  [tune] Allow fetching pinned objects from trainable functions (ray-project#1895)
  Multithreading refactor for ObjectManager. (ray-project#1911)
  Add slice functionality (ray-project#1832)
  [DataFrame] Pass read_csv kwargs to _infer_column (ray-project#1894)
  Addresses missed comments from multichunk object transfer PR. (ray-project#1908)
  Allow numpy arrays to be passed by value into tasks (and inlined in the task spec). (ray-project#1816)
  [xray] Lineage cache requests notifications from the GCS about remote tasks (ray-project#1834)
  Fix UI issue for non-json-serializable task arguments. (ray-project#1892)
  Remove unnecessary calls to .hex() for object IDs. (ray-project#1910)
  Allow multiple raylets to be started on a single machine. (ray-project#1904)

# Conflicts:
#	python/ray/rllib/__init__.py
#	python/ray/rllib/dqn/dqn.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertnishihara robertnishihara robertnishihara left review comments

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardliaw @AmplabJenkins @ericl @robertnishihara