Skip to content

[core] Cleanup dead pubsub related code#16629

Merged
ericl merged 8 commits intoray-project:masterfrom
wuisawesome:accessor_cleanup
Jun 25, 2021
Merged

[core] Cleanup dead pubsub related code#16629
ericl merged 8 commits intoray-project:masterfrom
wuisawesome:accessor_cleanup

Conversation

@wuisawesome
Copy link
Copy Markdown
Contributor

@wuisawesome wuisawesome commented Jun 23, 2021

Why are these changes needed?

This PR cleans up a good chunk of dead code related to redis pubsub.

  • Resource broadcast
  • Gcs task table
  • Unused subscribe to all actors.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@wuisawesome wuisawesome changed the title [WIP] Cleanup dead code Cleanup dead code Jun 24, 2021
@wuisawesome wuisawesome changed the title Cleanup dead code [core] Cleanup dead pubsub related code Jun 25, 2021
@ericl ericl merged commit bfe8532 into ray-project:master Jun 25, 2021
ericl added a commit to ericl/ray that referenced this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants