Skip to content

Revert "Unhandled exception handler based on local ref counting (#140…#14099

Merged
ericl merged 1 commit intoray-project:masterfrom
rkooo567:windows-failure
Feb 15, 2021
Merged

Revert "Unhandled exception handler based on local ref counting (#140…#14099
ericl merged 1 commit intoray-project:masterfrom
rkooo567:windows-failure

Conversation

@rkooo567
Copy link
Copy Markdown
Contributor

@rkooo567 rkooo567 commented Feb 15, 2021

…49)"

This reverts commit 9dc671a.
Windows build seems to be broken from this PR with this error.

(22:43:20) ERROR: BUILD.bazel:705:8: Couldn’t build file memory_store_test.exe: Linking of rule ‘//:memory_store_test’ failed (Exit 1120): link.exe failed: error executing command

cc @architkulkarni

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567
Copy link
Copy Markdown
Contributor Author

cc @ericl

@ericl ericl merged commit b45ae76 into ray-project:master Feb 15, 2021
ericl added a commit to ericl/ray that referenced this pull request Feb 15, 2021
ericl added a commit that referenced this pull request Feb 15, 2021
#14113)

* Revert "Revert "Unhandled exception handler based on local ref counting (#14049)" (#14099)"

This reverts commit b45ae76.

* reomve test

* fix

* fix
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
ray-project#14113)

* Revert "Revert "Unhandled exception handler based on local ref counting (ray-project#14049)" (ray-project#14099)"

This reverts commit b45ae76.

* reomve test

* fix

* fix
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@architkulkarni architkulkarni mentioned this pull request Feb 16, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants