Skip to content

[dask-on-ray] Fix Dask-on-Ray test: Python 3 dictionary .values() is a view, and is not indexable#13945

Merged
simon-mo merged 3 commits intomasterfrom
dask-on-ray/fix/py3-dict-values
Feb 6, 2021
Merged

[dask-on-ray] Fix Dask-on-Ray test: Python 3 dictionary .values() is a view, and is not indexable#13945
simon-mo merged 3 commits intomasterfrom
dask-on-ray/fix/py3-dict-values

Conversation

@clarkzinzow
Copy link
Copy Markdown
Contributor

@clarkzinzow clarkzinzow commented Feb 5, 2021 •
edited
Loading

Python 3 dictionary .values() is a view, and is not indexable.

Why are these changes needed?

Related issue number

Closes #13943

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo
Copy link
Copy Markdown
Contributor

simon-mo commented Feb 6, 2021

Can you fix lint?

diff --git a/python/ray/tests/test_dask_scheduler.py b/python/ray/tests/test_dask_scheduler.py
index 1ec730cda..54ba40521 100644
--- a/python/ray/tests/test_dask_scheduler.py
+++ b/python/ray/tests/test_dask_scheduler.py
@@ -36,7 +36,8 @@ def test_ray_dask_persist(ray_start_regular_shared):
     arr = da.ones(5) + 2
     result = arr.persist(scheduler=ray_dask_get)
     np.testing.assert_array_equal(
-        next(iter(result.dask.values())), np.ones(5) + 2)
+        next(iter(result.dask.values())),
+        np.ones(5) + 2)

@clarkzinzow
Copy link
Copy Markdown
Contributor Author

clarkzinzow commented Feb 6, 2021

@simon-mo I guess that's what I get for yolo-swagging this in the GitHub UI

@simon-mo simon-mo merged commit f070b3c into master Feb 6, 2021
@simon-mo simon-mo deleted the dask-on-ray/fix/py3-dict-values branch February 6, 2021 05:21
@clarkzinzow clarkzinzow mentioned this pull request Feb 8, 2021
Merged
6 tasks
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@clarkzinzow @fishbone
[dask-on-ray] Fix Dask-on-Ray test: Python 3 dictionary .values() is …
cb0303a 
…a view, and is not indexable (ray-project#13945)
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[dask-on-ray] Fix Dask-on-Ray test: Python 3 dictionary .valu…
a9a85be 
…es() is a view, and is not indexable (ray-project#13945)"

This reverts commit cb0303a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@rkooo567 rkooo567

@simon-mo simon-mo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_dask_scheduler is broken

3 participants

@clarkzinzow @simon-mo @rkooo567