Skip to content

Fix test_actor_restart#13901

Merged
stephanie-wang merged 1 commit intoray-project:masterfrom
antgroup:fix_test_actor_restart
Feb 5, 2021
Merged

Fix test_actor_restart#13901
stephanie-wang merged 1 commit intoray-project:masterfrom
antgroup:fix_test_actor_restart

Conversation

@raulchen
Copy link
Copy Markdown
Contributor

@raulchen raulchen commented Feb 4, 2021

Why are these changes needed?

This test is flaky. It can't pass on a slow machine.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Copy Markdown
Member

@kfstorm kfstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rkooo567
Copy link
Copy Markdown
Contributor

rkooo567 commented Feb 4, 2021

Can you wait until @stephanie-wang review?

@raulchen
Copy link
Copy Markdown
Contributor Author

raulchen commented Feb 4, 2021

Sure, no rush for me. But this is actually a pretty straightforward mistake...

@stephanie-wang stephanie-wang merged commit e1a5e5b into ray-project:master Feb 5, 2021
@kfstorm kfstorm deleted the fix_test_actor_restart branch February 7, 2021 08:55
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants