[serve] Built-in support for imported backends#13867
Merged
edoakes merged 9 commits intoray-project:masterfrom Feb 4, 2021
Merged
[serve] Built-in support for imported backends#13867edoakes merged 9 commits intoray-project:masterfrom
edoakes merged 9 commits intoray-project:masterfrom
Conversation
fcc1b65 to
34eacca
Compare
simon-mo
approved these changes
Feb 2, 2021
Comment on lines
+28
to
+29
| elif isinstance(backend_def, str): | ||
| return False |
Contributor
There was a problem hiding this comment.
This means the default max_concurrency in BackendConfig will be very high. Maybe special casing there?
Collaborator
Author
There was a problem hiding this comment.
Yeah good point. As we discussed offline I'm going to reduce the default max_concurrency for async case to 100.
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Easier to document this and push users towards it as it will be the recommended way to deploy models to production in the future.
Also adds the ability to import functions with the same mechanism.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.