[GCS]Fix bug that gcs client does not set last_resource_usage_#13856
[GCS]Fix bug that gcs client does not set last_resource_usage_#13856ffbin merged 3 commits intoray-project:masterfrom
Conversation
| protected: | ||
| NodeResourceInfoAccessor() = default; | ||
|
|
||
| private: |
There was a problem hiding this comment.
We’d better to keep this private flag. There's a method called GetLastResourceUsage for accessing this var.
There was a problem hiding this comment.
I made the following changes: GetLastResourceUsage returns the const pointer to prevent external modification of the value of last_resource_usage_, thx.
WangTaoTheTonic
left a comment
There was a problem hiding this comment.
Looks like setting resource usage cache was missed in new scheduling. Nice catch!
Just a tiny comment!
|
One question. What was the consequence of not having this before? I wonder why we couldn't catch this. How serious the issue was? |
rkooo567
left a comment
There was a problem hiding this comment.
Please answer the question above!
When new scheduler is enabled, it will affect the lightweight heartbeat reporting, because it does not set the node resource reported last time, so it is always considered that the node resource has changed and the node resource information needs to be reported. It affects performance, not functionality, so it's not found. |
ray-project#13856)" This reverts commit ca15a73.
Why are these changes needed?
gcs client does not set
last_resource_usage_when report resource usage, so we get last_resource_usage_ is empty.Related issue number
Checks
scripts/format.shto lint the changes in this PR.