[Serve] Revert "Revert "[Serve] Fix ServeHandle serialization"" and disable failing Windows test#13771
Merged
simon-mo merged 13 commits intoray-project:masterfrom Feb 4, 2021
Conversation
…rni/ray into fix-serialize-handle
simon-mo
approved these changes
Jan 28, 2021
Contributor
Author
|
|
Contributor
Author
|
Merged master to re-trigger CI and now there's a new kind of failure (npm errored?): https://travis-ci.com/github/ray-project/ray/jobs/480094615 @simon-mo have you seen anything like this before? Let me know if you have any ideas for what I should try next. |
Contributor
|
just re-ran the build, looks transient |
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…isable failing Windows test (ray-project#13771)
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…"" and disable failing Windows test (ray-project#13771)" This reverts commit 14c5222.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13753 and skips the failing Windows test (test_handle.py)
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.