Skip to content

[Placement Group] Support named placement group#13755

Merged
ffbin merged 25 commits intoray-project:masterfrom
antgroup:support_named_placement_group
Feb 5, 2021
Merged

[Placement Group] Support named placement group#13755
ffbin merged 25 commits intoray-project:masterfrom
antgroup:support_named_placement_group

Conversation

@clay4megtr
Copy link
Copy Markdown
Contributor

Why are these changes needed?

#13625

Related issue number

#13625

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clay4megtr
Copy link
Copy Markdown
Contributor Author

I will update the doc If there is nothing wrong with the overall api intergace. @rkooo567 @ffbin

@clay4megtr
Copy link
Copy Markdown
Contributor Author

@edoakes @rkooo567 hi, can you help to take a look for this pr ?

Copy link
Copy Markdown
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rkooo567
Copy link
Copy Markdown
Contributor

rkooo567 commented Feb 4, 2021

ASAN and lint failed

Copy link
Copy Markdown
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry two more comments haha

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 4, 2021
@clay4megtr clay4megtr removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 4, 2021
@ffbin ffbin merged commit fb89f9c into ray-project:master Feb 5, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants