[Placement Group] Move PlacementGroup public method to interface.#13629
Merged
kfstorm merged 38 commits intoray-project:masterfrom Jan 25, 2021
Merged
[Placement Group] Move PlacementGroup public method to interface.#13629kfstorm merged 38 commits intoray-project:masterfrom
kfstorm merged 38 commits intoray-project:masterfrom
Conversation
kfstorm
reviewed
Jan 22, 2021
java/runtime/src/main/java/io/ray/runtime/placementgroup/PlacementGroupImpl.java
Outdated
Show resolved
Hide resolved
chaokunyang
reviewed
Jan 25, 2021
chaokunyang
reviewed
Jan 25, 2021
kfstorm
approved these changes
Jan 25, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ace. (ray-project#13629)" This reverts commit 36bf58b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Now,
PlacementGroupis a empty interface in java api, user need to cast it toPlacementGroupImplif user want to invokewaitmethod, we should put these method to interface level.Related issue number
#13627
Checks
scripts/format.shto lint the changes in this PR.