Revert "[dashboard] Fix RAY_RAYLET_PID KeyError on Windows"#13572
Merged
Revert "[dashboard] Fix RAY_RAYLET_PID KeyError on Windows"#13572
Conversation
This reverts commit ef6d859.
Contributor
Author
|
Hey @fyrestone here is a PR to revert- but am curious, is there a reason this revert and the fix in #13253 need to be done separately as opposed to in the same PR? Also, I am not familiar with this code, so I will leave it to @edoakes to review and merge. Thanks! |
Contributor
Thanks. It's better to reverts the #12948 in a separate PR. |
Contributor
Author
edoakes
approved these changes
Jan 22, 2021
amogkam
added a commit
that referenced
this pull request
Jan 25, 2021
rkooo567
pushed a commit
that referenced
this pull request
Jan 25, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ct#12948)" (ray-project#13572) This reverts commit ef6d859.
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ndows (ray-project#12948)" (ray-project#13572)" (ray-project#13685)" This reverts commit b337a60.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ay-project#12948)" (ray-project#13572)" This reverts commit f09325a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #12948
As per @fyrestone on #13253, reverting this PR should fix #13199
Closes #13199