[Buildkite] Add all Python tests#13566
Merged
simon-mo merged 17 commits intoray-project:masterfrom Jan 26, 2021
Merged
Conversation
ijrsvt
reviewed
Jan 21, 2021
| --jobs=2 | ||
| //:all | ||
|
|
||
| - label: ":serverless: Dashboard + Serve Tests" |
Contributor
There was a problem hiding this comment.
the smallest nit,
Can we use a different Emoji for this?
ijrsvt
reviewed
Jan 21, 2021
| head_node_args={ | ||
| "num_cpus": 10, | ||
| "redis_max_memory": 10**7 | ||
| "redis_max_memory": 10**8 |
Contributor
There was a problem hiding this comment.
OOC, why are we upping all of these? Is it because we have more resources per CI box.
ijrsvt
reviewed
Jan 21, 2021
Contributor
ijrsvt
left a comment
There was a problem hiding this comment.
Looks good, should we hold off until asan actually passes on buildkite?
| # TODO(maximsmol): we should probably block until the processes actually | ||
| # all died somehow | ||
| # Wait for the processes to actually stop. | ||
| psutil.wait_procs(stopped, timeout=2) |
Contributor
There was a problem hiding this comment.
Great fix!!!!
Can we catch this and suggest that the user retries with --force?
| - DOC_TESTING=1 ./ci/travis/install-dependencies.sh | ||
| - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-tf,-pytorch,-py37 doc/... | ||
| - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=tf,-pytorch,-py37 doc/... | ||
| - bazel test --config=ci $(./scripts/bazel_export_options) --build_tests_only --test_tag_filters=-tf,pytorch,-py37 doc/... No newline at end of file |
Contributor
Author
|
Java was broken for unrelated reason. |
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
This reverts commit e205095.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds additional tests to buildkite: