Skip to content

Remove idle actor from worker pool.#13523

Merged
ffbin merged 3 commits intoray-project:masterfrom
antgroup:remove_actor_task
Jan 23, 2021
Merged

Remove idle actor from worker pool.#13523
ffbin merged 3 commits intoray-project:masterfrom
antgroup:remove_actor_task

Conversation

@jovany-wang
Copy link
Copy Markdown
Contributor

Why are these changes needed?

Since actor tasks are transported in direct call, we should not have idle_actor to indicate idle worker for actor tasks any more.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Copy Markdown
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change :)

@ffbin
Copy link
Copy Markdown
Contributor

ffbin commented Jan 23, 2021

Failed CI jobs seem irrelevant.

@ffbin ffbin merged commit 8ef835f into ray-project:master Jan 23, 2021
@jovany-wang jovany-wang deleted the remove_actor_task branch January 23, 2021 08:56
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants