[Kubernetes] Unit test for cluster launch and teardown using K8s Operator#13437
Merged
edoakes merged 6 commits intoray-project:masterfrom Jan 21, 2021
Merged
Conversation
edoakes
approved these changes
Jan 19, 2021
b709a3e to
297677b
Compare
DmitriGekhtman
commented
Jan 19, 2021
| "| grep ^example-cluster: | tail -n 100" | ||
| log_tail = subprocess.check_output(cmd, shell=True).decode() | ||
| return ("head-node" in log_tail) and ("worker-nodes" in log_tail) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Decided to simplify this a bit to avoid running issues with monitor log format changes.
This plus the pod quantity checks should be sufficient.
DmitriGekhtman
commented
Jan 19, 2021
| # Retry 60 times with 1 second delay between attempts. | ||
| def f_with_retries(*args, **kwargs): | ||
| for _ in range(60): | ||
| if f(*args, **kwargs): |
Contributor
Author
There was a problem hiding this comment.
Extended the timeout from 30 retries to 60 to get it to consistently pass on minikube.
5 tasks
Contributor
|
@edoakes , can you please merge this? |
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…K8s Operator (ray-project#13437)" This reverts commit 5b080c1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds a unit test for cluster launch and teardown using the K8s Operator.
Also, updates the
sizeof K8s tests intests/BUILDfromsmalltomedium.If I understand correctly, the
sizedetermines a timeout. These test could potentially take longer than a minute.Related issue number
Checks
scripts/format.shto lint the changes in this PR.Test passes locally using minikube with Kubernetes server version v1.19.0 and 1.20.1.