Skip to content

[ray_client] Implement optional arguments to ray.remote() and f.options()#12985

Merged
ericl merged 23 commits intoray-project:masterfrom
barakmich:client_options
Dec 20, 2020
Merged

[ray_client] Implement optional arguments to ray.remote() and f.options()#12985
ericl merged 23 commits intoray-project:masterfrom
barakmich:client_options

Conversation

@barakmich
Copy link
Copy Markdown
Contributor

Why are these changes needed?

Related issue number

Depends on #12964
Closes #12282

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Change-Id: I586023573dc3653e816a9329416a75ba127e460d
Change-Id: I0b32cc93abbba0024df52f7f368edaed1a6da9ec
Change-Id: Idb225b9edb121d1b8285ef133f37ee94295133c4
Change-Id: I782f3f92892128ab12126cae876e872b9231b79d
Change-Id: Ic528d587cc29b892e9ee0139cda0222de5e5c730
Change-Id: I7b30456cc50e01023d7164ee6408059227b2f250
Change-Id: I2d2a46a48d060e77c7a2be2b65e3f2b5f3e246c0
Change-Id: I0762b67d335817af42303671c201b6770a24ad35
Change-Id: If5ef594116b83b66f8e506ee63143103ce63b0a4
Change-Id: Ia953d51cec9ed53640445618db8a08b81c833c1f
Change-Id: Ia020aa2ec49a700b9daaf06546d7d6a251599968
Change-Id: Ic4f6723d610de6df6cdb061933309570cac92e55
Change-Id: I3afaceb728c36bd2eeac01889ffb385cbeeceeef
Change-Id: I506af9fb66f2155856cc3b4bf74ef6847b630863
Change-Id: Idbda7ab8bf17fd8c693282398e032c153657b482
Change-Id: If140ba8cff55de9b1218d3042b60ae703ef16319
Change-Id: I39eec6b8bca7431b3734178f23677db26a7393a3
Change-Id: I7784eba3c225b7dc709dbd5e68b57eb4f0d4981f
Change-Id: I5279e074b575f95446911bfe5333f90abe254c3e
Change-Id: I61e0426c3bdb78bdc5baeb30f142b2f7c4e793cd
Change-Id: I8d04047fa463ae4ffe3ba5d12b0053108c5f2b5f
@barakmich barakmich added this to the Ray Client milestone Dec 19, 2020
@barakmich barakmich added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 20, 2020
@ericl
Copy link
Copy Markdown
Contributor

ericl commented Dec 20, 2020

Merge conflict. Probably you want to pull in your original base branch, and then pull in latest master after that, to avoid having to redundantly resolve conflicts.

Edit: I had to merge master into client_testbasic, and then merge client_testbasic into this branch for a clean resolution.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 20, 2020
@ericl ericl removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 20, 2020

// A message representing the valid options to modify a task exectution
//
// TODO(barakmich): In the longer term, if everything were a client,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Fine for now

@ericl
Copy link
Copy Markdown
Contributor

ericl commented Dec 20, 2020

[waiting for travis]

@ericl ericl removed the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 20, 2020
@ericl ericl merged commit 80f6dd1 into ray-project:master Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pipe Remote Function options (eg num_cpus=1) through the Schedule RPC [3]

2 participants