[ray_client] Integrate with test_basic, test_basic_2 and test_actor#12964
Merged
ericl merged 12 commits intoray-project:masterfrom Dec 20, 2020
Merged
[ray_client] Integrate with test_basic, test_basic_2 and test_actor#12964ericl merged 12 commits intoray-project:masterfrom
ericl merged 12 commits intoray-project:masterfrom
Conversation
dcbd498 to
fd7fc02
Compare
fd7fc02 to
cdc62ae
Compare
ericl
reviewed
Dec 18, 2020
Contributor
ericl
left a comment
There was a problem hiding this comment.
LGTM. Btw, we should make sure to enable the tests that use _remote later on, it's not really an internal API (it's equivalent to foo.options().remote(), or defining a new @remote function). A lot of the tests are just using _remote since the tests were written a long time ago to save lines of code.
Contributor
Author
|
Discovered that one of the fixes for test_actor broke test_basic -- and found that there was a bug. Fixed now, but worth another look. Also, opened #12983 as a result -- marked P3 and added to the milestone but it's ready to happen soon (yay code deletion!) |
6 tasks
Contributor
|
~/build/ray-project/tmp.XLUq6hHlRA |
Change-Id: I586023573dc3653e816a9329416a75ba127e460d
Change-Id: I0b32cc93abbba0024df52f7f368edaed1a6da9ec
Change-Id: Idb225b9edb121d1b8285ef133f37ee94295133c4
Change-Id: I782f3f92892128ab12126cae876e872b9231b79d
Change-Id: Ic528d587cc29b892e9ee0139cda0222de5e5c730
Change-Id: I7b30456cc50e01023d7164ee6408059227b2f250
Change-Id: I2d2a46a48d060e77c7a2be2b65e3f2b5f3e246c0
Change-Id: I0762b67d335817af42303671c201b6770a24ad35
Change-Id: If5ef594116b83b66f8e506ee63143103ce63b0a4
Change-Id: Ia953d51cec9ed53640445618db8a08b81c833c1f
Change-Id: Ia020aa2ec49a700b9daaf06546d7d6a251599968
Change-Id: Ic4f6723d610de6df6cdb061933309570cac92e55
6e482e2 to
4d86879
Compare
ericl
approved these changes
Dec 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Brings the client in line with our usual unit tests. Skips tests if the functionality is internal (not exposed in the ray client API), if the functionality has a ticket in this milestone (mostly regarding passing options like num_cpu), grpc message size issues that datastreaming can relatively easily handle (for a future milestone) or on rare occasion, a completely odd reason altogether.
Current stats:
test_basic: 23 pass, 11 skip
test_basic_2: 16 pass, 8 skip
test_actor: 27 pass, 9 skip
Related issue number
Depends on #12818
Closes #12422
Checks
scripts/format.shto lint the changes in this PR.