[Collective][PR 3/6] Other collectives#12864
Merged
richardliaw merged 7 commits intoray-project:masterfrom Dec 21, 2020
Merged
Conversation
6 tasks
Contributor
Author
6 tasks
richardliaw
reviewed
Dec 17, 2020
richardliaw
reviewed
Dec 17, 2020
Contributor
richardliaw
left a comment
There was a problem hiding this comment.
Roughly looks good (skipped most of the test code!)
Ping when comments addressed.
python/ray/util/collective/tests/distributed_tests/test_distributed_reducescatter.py
Outdated
Show resolved
Hide resolved
python/ray/util/collective/tests/distributed_tests/test_distributed_allreduce.py
Outdated
Show resolved
Hide resolved
python/ray/util/collective/collective_group/nccl_collective_group.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@richardliaw all comments addressed. Test passed on my local cluster. Fine to merge! |
richardliaw
approved these changes
Dec 21, 2020
Contributor
richardliaw
left a comment
There was a problem hiding this comment.
thanks! will merge after master shows lint passes
6 tasks
cathrinS
pushed a commit
to cathrinS/ray
that referenced
this pull request
Dec 29, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is the third PR for the project Collective-in-Ray.
To make each PR more manageable and friendly to reviewers, we break the entire project code into 6 incremental PRs:
See a list below:
(merged) Basic infrastructure; an in-actor collective interfaceray.util.collective.init_collective_group(*args, **kwargs); support for two collectivesallreduceandbarrier; some testing infrastructure, etc.actor.options(collective_options, ...).remote()and the third interfacedeclare_collective_group(actors, collective_options, ...).allgather,broadcast,reduce,reducescatter; refactor the tests into distributed tests and single-node cluster tests.This is the third one (3/6).
Related issue number
RFC #12174
Checks
scripts/format.shto lint the changes in this PR.