Skip to content

[Dashboard] Add the new dashboard code and prompt users to try it#11667

Merged
raulchen merged 12 commits intoray-project:masterfrom
mxz96102:ant_new_dashbaord_fe
Jan 29, 2021
Merged

[Dashboard] Add the new dashboard code and prompt users to try it#11667
raulchen merged 12 commits intoray-project:masterfrom
mxz96102:ant_new_dashbaord_fe

Conversation

@mxz96102
Copy link
Copy Markdown
Contributor

@mxz96102 mxz96102 commented Oct 28, 2020 •
edited
Loading

Why are these changes needed?

Immigration of the ant new dashboard, like we talking about last week.
The old dashboard is also maintained inside, we will remove it once everything is ready.
image

image

The old dashboard connects with the new one with a link.
Instead of using change origin, using package.json proxy to connect API server to backend

Related issue number

#10018

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@mxz96102 mxz96102 changed the title [Dashboard] Immigrate ant dashboard to lecacy one [Dashboard] Immigrate ant dashboard to legacy one Oct 28, 2020
mxz96102
mxz96102 commented Oct 28, 2020
View reviewed changes
ashione
ashione reviewed Oct 29, 2020
View reviewed changes
@fyrestone fyrestone added the dashboard Issues specific to the Ray Dashboard label Nov 3, 2020
@kfstorm
Copy link
Copy Markdown
Member

kfstorm commented Nov 3, 2020

I don't understand the title of this PR. @mxz96102 Are you trying to enable the new dashboard by default?

@mxz96102
Copy link
Copy Markdown
Contributor Author

mxz96102 commented Nov 4, 2020

I don't understand the title of this PR. @mxz96102 Are you trying to enable the new dashboard by default?

@kfstorm Users are using the current dashboard by default, and we provide a button to guide them try new dashboard.

@kfstorm
Copy link
Copy Markdown
Member

kfstorm commented Nov 4, 2020

@mxz96102 How about changing the title to "[Dashboard] Add the new dashboard code and prompt users to try it"?

@mxz96102 mxz96102 changed the title [Dashboard] Immigrate ant dashboard to legacy one [Dashboard] Add the new dashboard code and prompt users to try it Nov 5, 2020
@mxz96102
Copy link
Copy Markdown
Contributor Author

mxz96102 commented Nov 10, 2020

@mfitton Is there anything wrong with this pr? Please review and let me know if there is~

@fyrestone fyrestone mentioned this pull request Dec 16, 2020
Merged
6 tasks
@fyrestone fyrestone mentioned this pull request Dec 25, 2020
Merged
6 tasks
@fyrestone fyrestone mentioned this pull request Jan 4, 2021
Merged
6 tasks
@raulchen raulchen requested a review from edoakes January 7, 2021 12:22
@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jan 26, 2021

@raulchen @mxz96102 I just tried this out, but it seems that the jobs, actors, and logs pages are not working.

  • The jobs page just hangs forever with a loading icon.
  • The actors page renders but I started an actor on the cluster and it did not show up in the dashboard.
  • The logs page only shows "Failed to load" (screenshot below).

Screen Shot 2021-01-26 at 3 56 24 PM

@mxz96102
Copy link
Copy Markdown
Contributor Author

mxz96102 commented Jan 27, 2021

@raulchen @mxz96102 I just tried this out, but it seems that the jobs, actors, and logs pages are not working.

  • The jobs page just hangs forever with a loading icon.
  • The actors page renders but I started an actor on the cluster and it did not show up in the dashboard.
  • The logs page only shows "Failed to load" (screenshot below).
Screen Shot 2021-01-26 at 3 56 24 PM

This may due to code sync, I didn't update the backend code with this branch. Now I merged the master, these problems are supposed to be solved now.

@edoakes
Copy link
Copy Markdown
Collaborator

edoakes commented Jan 27, 2021

Thanks @mxz96102 I'll take another look tomorrow.

edoakes
edoakes approved these changes Jan 29, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxz96102 @raulchen it seems to be working now!

I'm ok to merge this with the following change: can we place change the naming of the buttoms from "TRY NEW DASHBOARD" to "TRY EXPERIMENTAL DASHBOARD" and "BACK TO LEGACY" to "BACK TO EXISTING DASHBOARD"? I'd also like it if we could remove the "SUMMARY" page entirely as it's basically just a blank screen right now.

I have a bunch of other small feedback on how we can improve this dashboard before we ask for feedback from OSS users. I will file this under a github milestone in the couple of days.

@mxz96102
Copy link
Copy Markdown
Contributor Author

mxz96102 commented Jan 29, 2021

@edoakes Thanks, I'm glad to have feedback with your team, it's important that we can hear your opinion and improve dashboard together

@raulchen raulchen merged commit 752da83 into ray-project:master Jan 29, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@mxz96102 @fishbone
[Dashboard] Add the new dashboard code and prompt users to try it (ra…
c536c4d 
…y-project#11667)
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[Dashboard] Add the new dashboard code and prompt users to tr…
165af32 
…y it (ray-project#11667)"

This reverts commit c536c4d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashione ashione ashione left review comments

@edoakes edoakes edoakes approved these changes

Assignees

@mfitton mfitton

Labels

dashboard Issues specific to the Ray Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mxz96102 @kfstorm @edoakes @ashione @raulchen @mfitton @fyrestone