[tune/dashboard] Fix Tune dashboard to work with all trainables#11232
Merged
richardliaw merged 1 commit intoray-project:masterfrom Oct 6, 2020
Merged
[tune/dashboard] Fix Tune dashboard to work with all trainables#11232richardliaw merged 1 commit intoray-project:masterfrom
richardliaw merged 1 commit intoray-project:masterfrom
Conversation
mfitton
approved these changes
Oct 6, 2020
Contributor
mfitton
left a comment
There was a problem hiding this comment.
Looks good. I'll make a follow-up PR to move it to the new dashboard infrastructure as well (we're mid-transition and going to flip the switch any day now). Thanks Kai!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The Tune dashboard currently does not work for trainables that do not report a
episode_reward_meanmetric. This is due to two bugs:Analysis.dataframe()method, themetricandmodeshould be optional, but they weren't strictly optional.collect()method of the dashboard, a dataframe was requested explicitly sorted byepisode_reward_mean. This excludes all but RLLib trainables.A follow-up PR might deal with error reporting - right now setting the Tune dir works, but fetching the trials lead to a silent internal error.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.