fix(canvas)!: use full block for Marker::Block#133
Merged
orhun merged 1 commit intoratatui:mainfrom Apr 15, 2023
Merged
Conversation
Member
Author
|
Changed |
74f0006 to
5b36533
Compare
Member
Author
|
(Tests fixed) |
When drawing a vertical line on a canvas, using `Marker::Block` would draw a gap in between each line. This is because the default block character was a half bar. This changes the default block character to a full block, and adds a new marker type `Marker::Bar` to replace the current `Marker::Block`. BREAKING CHANGE: `Marker::Block` now uses a full block character, and `Marker::Bar` is the new half block character. - Adds tests for each `Marker` in the canvas widget. - Adds marker to the canvas example to show the difference between the marker types.
Member
Author
|
sigh in improving the tests, I was too hasty and introduced a typo bug (which is now fixed, and should succeed). |
mindoodoo
approved these changes
Apr 14, 2023
sayanarijit
approved these changes
Apr 15, 2023
orhun
approved these changes
Apr 15, 2023
takumi-earth
pushed a commit
to earthlings-dev/ratatui
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82
When drawing a vertical line on a canvas, using
Marker::Blockwoulddraw a gap in between each line. This is because the default block
character was a half bar. This changes the default block character to a
full block, and adds a new marker type
Marker::Barto replace thecurrent
Marker::Block.BREAKING CHANGE:
Marker::Blocknow uses a full block character, andMarker::Baris the new half block character.Markerin the canvas widget.the marker types.