drm:vc4 Added calls for firmware display blank/unblank#3289
Merged
popcornmix merged 1 commit intorpi-4.19.yfrom Oct 28, 2019
Merged
drm:vc4 Added calls for firmware display blank/unblank#3289popcornmix merged 1 commit intorpi-4.19.yfrom
popcornmix merged 1 commit intorpi-4.19.yfrom
Conversation
Contributor
Author
|
Fixes #3050 |
pelwell
reviewed
Oct 16, 2019
b929714 to
e9c52f7
Compare
6by9
reviewed
Oct 16, 2019
| struct drm_encoder base; | ||
| bool hdmi_monitor; | ||
| bool rgb_range_selectable; | ||
| int display_num; |
Contributor
There was a problem hiding this comment.
I feel that this should be accessible from either the crtc or connector (the bits either side of the encoder).
In reality I get lost with the potential dereferencing between the structures, and this driver is fairly monolithic anyway.
Contributor
Author
There was a problem hiding this comment.
I did spend about 45 minutes trying to find a way of getting this information from the existing structures, and it ended up being so convoluted that adding this parameter was a hugely simpler option - both from an implementation and understanding point of view.
Contributor
There was a problem hiding this comment.
Fair enough. I know that finding the right linkings can be less than obvious.
Requires new display power mailbox call to be present. Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
e9c52f7 to
11e0604
Compare
Contributor
Author
|
@popcornmix This can be merged now that that required mailbox command in the firmware has been merged, unless you want a short delay to wait for it to go out in rpi-update. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Oct 28, 2019
See: raspberrypi/linux#3296 kernel: dts: bcm2838: Disable DWC OTG block by default kernel: ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support See: raspberrypi/linux#3295 kernel: bcm2835-v4l2-codec fixes See: raspberrypi/linux#3293 kernel: drm:vc4 Added calls for firmware display blank/unblank See: raspberrypi/linux#3289 firmware: arm_loader: Fix explicit kernel name handling See: #1277 firmware: Added a new display power mailbox call firmware: Update display_power gencmd with optional display id See: raspberrypi/linux#3050 firmware: Remove legacy pkgconfig to avoid Mesa conflicts See: raspberrypi/userland#585
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Oct 28, 2019
See: raspberrypi/linux#3296 kernel: dts: bcm2838: Disable DWC OTG block by default kernel: ALSA: usb-audio: Add Gustard U16/X26 to quirks for native DSD support See: raspberrypi/linux#3295 kernel: bcm2835-v4l2-codec fixes See: raspberrypi/linux#3293 kernel: drm:vc4 Added calls for firmware display blank/unblank See: raspberrypi/linux#3289 firmware: arm_loader: Fix explicit kernel name handling See: raspberrypi/firmware#1277 firmware: Added a new display power mailbox call firmware: Update display_power gencmd with optional display id See: raspberrypi/linux#3050 firmware: Remove legacy pkgconfig to avoid Mesa conflicts See: raspberrypi/userland#585
This was referenced Nov 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires new display power mailbox call to be present.
Signed-off-by: James Hughes james.hughes@raspberrypi.org