Override default progress mode for distributed-ucxx#453
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-0.45from Jul 3, 2025
Merged
Conversation
This was referenced Jul 2, 2025
| # environment, so the user's external environment can safely | ||
| # override things here. | ||
| ucxx.init(options=ucx_config, env_takes_precedence=True) | ||
| progress_mode = None if "UCXPY_PROGRESS_MODE" in os.environ else "blocking" |
Contributor
There was a problem hiding this comment.
Do we care what the value of the UCXPY_PROGRESS_MODE environment variable is?
| if local_addr: | ||
| assert local_addr.startswith("ucxx") | ||
| assert peer_addr.startswith("ucxx") | ||
| assert local_addr.startswith(("ucx://", "ucxx://")) |
Contributor
There was a problem hiding this comment.
Can this be tested yet, or not until the other PR is merged?
Member
Author
There was a problem hiding this comment.
Not until rapidsai/rapids-dask-dependency#116 is merged, and I think not even after, because we can't use another protocol to hit this conditional, or at least not easily. Probably not worth the time invested at the moment.
wence-
approved these changes
Jul 3, 2025
Member
Author
|
@TomAugspurger anything else here or are you good with previous answers? |
Member
Author
|
Thanks both of you! |
Member
Author
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/rapids-dask-dependency
that referenced
this pull request
Jul 3, 2025
Add a proxy communication backend to enable UCXX when `protocol="ucx"`, overriding UCX-Py. Additionally, provide warnings when UCXX is not installed letting the user know UCX-Py is EOL and will be removed, as well as a proper fallback `protocol="ucx-old"` to continue using UCX-Py while it's not completely archived. Depends on rapidsai/dask-cuda#1516 and rapidsai/ucxx#453. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Tom Augspurger (https://github.com/TomAugspurger) - Vyas Ramasubramani (https://github.com/vyasr) - Richard (Rick) Zamora (https://github.com/rjzamora) URL: #116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the default distributed-ucxx progress mode to
"blocking", which is equivalent to UCX-Py's default progress mode, allowing a more transparent move of Dask to UCXX. This change may later be reverted once we have more confidence in a successful transition to UCXX.Additionally allow both
"ucx://"and"ucxx://"address prefixes, since with the change from rapidsai/rapids-dask-dependency#116 both will be valid to enable UCXX when distributed-ucxx is installed.