Skip to content

Conversation

@pre-commit-ci
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Dec 1, 2025

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.14.3 → v0.14.7](astral-sh/ruff-pre-commit@v0.14.3...v0.14.7)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from c8d970e to 4fbbbbe Compare December 1, 2025 19:41
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner December 1, 2025 19:41
@pre-commit-ci pre-commit-ci bot requested a review from msarahan December 1, 2025 19:41
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 1, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jameslamb jameslamb requested review from jameslamb and removed request for msarahan December 2, 2025 15:57
@jameslamb
Copy link
Member

/ok to test 4fbbbbe

@jameslamb
Copy link
Member

jameslamb commented Dec 2, 2025

build-*-manifest CI jobs are failing like this:

docker.io/rapidsai/staging:docker-cuvs-bench-820-26.02a-cuda13-py3.10-amd64 is a manifest list
Error: Process completed with exit code 1.

(build link)

Looks like in newer versions of docker, builds create manifest lists by default instead of single image builds:

I'll try to push changes to fix that.

@jameslamb jameslamb self-assigned this Dec 2, 2025
rapids-bot bot pushed a commit that referenced this pull request Dec 2, 2025
Closes #820

*(description copied from #820 (comment)

`build-*-manifest` CI jobs are failing like this:

```text
docker.io/rapidsai/staging:docker-cuvs-bench-820-26.02a-cuda13-py3.10-amd64 is a manifest list
Error: Process completed with exit code 1.
```

([build link](https://github.com/rapidsai/docker/actions/runs/19864919436/job/56926457521?pr=820#step:4:23))

Looks like in newer versions of `docker`, builds create manifest lists by default instead of single image builds:

* NVIDIA/gpu-operator#1940
* NVIDIA/k8s-driver-manager#132
* docker/build-push-action#1339 (comment)

This opts out of that using the configuration option added in docker/build-push-action#1343

It also updates all `pre-commit` hooks, to avoid needing another CI run for #820

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #821
@jameslamb
Copy link
Member

superseded by #821

@jameslamb jameslamb closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants