This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Add geometry_generator factory for programmatic generation of geometry arrays#998
Merged
rapids-bot[bot] merged 49 commits intorapidsai:branch-23.04from Mar 22, 2023
Merged
Conversation
…into feature/polygon_distances
…into feature/polygon_distances
geometry_generator factory for programmatic generation of geometry arraysgeometry_generator factory for programmatic generation of geometry arrays
3 tasks
harrism
approved these changes
Mar 20, 2023
Member
harrism
left a comment
There was a problem hiding this comment.
Minor comments. Thanks for this utility!
cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/ranges/multipolygon_range.cuh
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 23, 2023
This PR separates the `pairwise_point_polygon_distance` benchmark portion of PR #1002. While that PR is only left for nvtx3 experiments. # Original PR description: This PR adds pairwise point polygon distance benchmark. Depends on #998 Point-polygon distance performance can be affected by many factors, because the geometry is complex in nature. I benchmarked these questions: 1. How does the algorithm scales with simple multipolygons? 2. How does it scales with complex multipolygons? ## How does the algorithm scales with simple multipolygons? The benchmark uses the most simple multipolygon, 3 sides per polygon, 0 hole and 1 polygon per multipolygon. Float32 | Num multipolygon | Throughput (#multipolygons / s) | | --- | --- | | 1 | 28060.32971 | | 100 | 2552687.469 | | 10000 | 186044781 | | 1000000 | 1047783101 | | 100000000 | 929537385.2 | Float64 | Num multipolygon | Throughput (#multipolygons / s) | | --- | --- | | 1 | 28296.94817 | | 100 | 2491541.218 | | 10000 | 179379919.5 | | 1000000 | 854678939.9 | | 100000000 | 783364410.7 |  The chart shows that with simple polygons and simple multipoint (1 point per multipoint), the algorithm scales pretty nicely. Throughput is maxed out at near 1M pairs. ## How does the algorithm scales with complex multipolygons? The benchmark uses a complex multipolygon, 100 edges per ring, 10 holes per polygon and 3 polygons per multipolygon. float32 Num multipolygon | Throughput (#multipolygons / s) -- | -- 1000 | 158713.2377 10000 | 345694.2642 100000 | 382849.058 float64 Num multipolygon | Throughput (#multipolygons / s) -- | -- 1000 | 148727.1246 10000 | 353141.9758 100000 | 386007.3016  The algorithm reaches max throughput at near 10K pairs. About 100X lower than the simple multipolygon example. Authors: - Michael Wang (https://github.com/isVoid) - Mark Harris (https://github.com/harrism) Approvers: - Mark Harris (https://github.com/harrism) URL: #1131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To allow easy benchmarking for future APIs, I created
geometry_generatorthat programmatically generate a geoarrow compliant geometry arrays. The first feature landing isgenerate_multipolygon_array.This PR also adds
BaseFixtureWithParam, which allows user to parameterize the tests with value and ranges.Contributes to #259
Checklist