Skip to content

upgrade dlpack to 0.5#8262

Merged
kkraus14 merged 32 commits intorapidsai:branch-21.06from
cwharris:updgrade-dlpack-0.5
May 25, 2021
Merged

upgrade dlpack to 0.5#8262
kkraus14 merged 32 commits intorapidsai:branch-21.06from
cwharris:updgrade-dlpack-0.5

Conversation

@cwharris
Copy link
Contributor

@cwharris cwharris commented May 17, 2021 •
edited
Loading

Update dlpack from 0.3 to >=0.5,<0.6.0a0, and fix for breaking changes introduced in 0.4.

closes #7679

@cwharris cwharris added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 17, 2021
@cwharris cwharris requested a review from a team as a code owner May 17, 2021 16:31
@cwharris cwharris added the feature request New feature or request label May 17, 2021
@github-actions github-actions bot added the CMake CMake build issue label May 17, 2021
@cwharris cwharris requested review from kkraus14 and trxcllnt May 17, 2021 16:32
kkraus14
kkraus14 reviewed May 17, 2021
View reviewed changes
@cwharris
Copy link
Contributor Author

cwharris commented May 17, 2021

waiting for conda-forge to get updated with dlpack 0.5 so I can test.

@cwharris cwharris added 0 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels May 17, 2021
@kkraus14 kkraus14 added 2 - In Progress Currently a work in progress and removed 0 - Waiting on Author Waiting for author to respond to review labels May 17, 2021
@cwharris cwharris requested review from a team as code owners May 18, 2021 15:08
@cwharris cwharris requested a review from mythrocks May 18, 2021 15:08
galipremsagar
galipremsagar approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the errors I was seeing. Thanks @cwharris !

mythrocks
mythrocks reviewed May 18, 2021
View reviewed changes
mythrocks
mythrocks approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@cwharris, could we consider updating this PR's description with a very brief description of #7679, indicating that dmlc/dlpack had a breaking change in 0.3-0.4?
I suspect the git log commit message will be more informative then.

@github-actions github-actions bot added the conda label May 18, 2021
@github-actions github-actions bot removed the gpuCI label May 24, 2021
@github-actions github-actions bot added the gpuCI label May 24, 2021
@github-actions github-actions bot removed the gpuCI label May 25, 2021
@jakirkham jakirkham mentioned this pull request May 25, 2021
Merged
@cwharris cwharris added 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working and removed 2 - In Progress Currently a work in progress feature request New feature or request labels May 25, 2021
@jakirkham
Copy link
Member

jakirkham commented May 25, 2021

Guessing this will eventually run into the Python test failures we are fixing in PR ( #8342 ). So this may need an admin merge (though probably worth waiting to make sure those are the only failures on CI)

@cwharris
Copy link
Contributor Author

cwharris commented May 25, 2021

Looks like we're failing due to the errors which will be fixed by #8342 .

17:29:55 Traceback (most recent call last):
17:29:55   File "<string>", line 1, in <module>
17:29:55   File "/workspace/.conda-bld/dask-cudf_1621981592845/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.8/site-packages/dask_cudf/__init__.py", line 6, in <module>
17:29:55     from . import backends
17:29:55   File "/workspace/.conda-bld/dask-cudf_1621981592845/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.8/site-packages/dask_cudf/backends.py", line 9, in <module>
17:29:55     from dask.dataframe.core import get_parallel_type, make_meta, meta_nonempty
17:29:55 ImportError: cannot import name 'make_meta' from 'dask.dataframe.core' (/workspace/.conda-bld/dask-cudf_1621981592845/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.8/site-packages/dask/dataframe/core.py)

@cwharris
Copy link
Contributor Author

cwharris commented May 25, 2021

@kkraus14 Ok to do an admin merge here?

@kkraus14 kkraus14 merged commit eea8cab into rapidsai:branch-21.06 May 25, 2021
@isVoid isVoid mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@robertmaynard robertmaynard robertmaynard left review comments

@kkraus14 kkraus14 kkraus14 approved these changes

@mythrocks mythrocks mythrocks approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

+1 more reviewer

@raydouglass raydouglass raydouglass approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEA] Support dlpack >= 0.4

9 participants

@cwharris @kkraus14 @jakirkham @trxcllnt @robertmaynard @raydouglass @mythrocks @galipremsagar @revans2