-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
CMakeCMake build issueCMake build issuefeature requestNew feature or requestNew feature or requestlibcudfAffects libcudf (C++/CUDA) code.Affects libcudf (C++/CUDA) code.
Description
Is your feature request related to a problem? Please describe.
Building cudf against dlpack main currently fails due to:
dmlc/dlpack@8323706#diff-1564e5abd0da5cf46e82b28b0058996df944007494520a2b0a6b629880eaa097
which renamed ctx to device.
For example:
/.../rapids/cudf/cpp/src/interop/dlpack.cpp:229:10: error: ‘struct DLTensor’ has no member named ‘ctx’
229 | tensor.ctx.device_type = kDLGPU;
| ^~~
This change has been tagged as dlpack 0.4, with Issue: dmlc/dlpack#61. So it seems like this change is permanent going-forward
Describe the solution you'd like
Dlpack interop code changd to support the new device changes.
Describe alternatives you've considered
Either a documentation note to mentior, or an explicit compile-time version check against DLPack < 0.4.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
CMakeCMake build issueCMake build issuefeature requestNew feature or requestNew feature or requestlibcudfAffects libcudf (C++/CUDA) code.Affects libcudf (C++/CUDA) code.