Refactor ORC reader#13396
Merged
rapids-bot[bot] merged 53 commits intorapidsai:branch-23.08from Jun 28, 2023
Merged
Conversation
# Conflicts: # cpp/src/io/orc/reader_impl.cu # cpp/src/io/orc/reader_impl.hpp
ae2ba31 to
f38a56c
Compare
vuule
reviewed
Jun 14, 2023
Contributor
vuule
left a comment
There was a problem hiding this comment.
I'm glad this PR is kept simple. Even this much is hard to review because of code shuffle. It should make future PRs much easier on the eye :)
# Conflicts: # cpp/src/io/orc/reader_impl.cu
vuule
reviewed
Jun 26, 2023
vuule
approved these changes
Jun 26, 2023
mythrocks
reviewed
Jun 27, 2023
mythrocks
reviewed
Jun 28, 2023
cpp/src/io/orc/reader_impl.cu
Outdated
| stream); | ||
|
|
||
| // Value for checking whether we decompress successfully. | ||
| // It doesn't need to be atomic as there is no race condition: we only write `false` if needed. |
mythrocks
approved these changes
Jun 28, 2023
Contributor
mythrocks
left a comment
There was a problem hiding this comment.
LGTM! It certainly reads much better now.
Contributor
Author
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 29, 2023
…kernel (#13643) Fixes memcheck regression in ORC reader uncompressed logic. The regression was introduced in #13396. The original fix is copied from #13586 The error was caught by the nightly build here: https://github.com/rapidsai/cudf/actions/runs/5409203449/jobs/9829059618 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #13643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rewrites the implementation ORC reader, preparing for the next changes in ORC chunked reader:
streamparameter from theread()API. Instead,streamandmrare stored upon reader construction.There is not any new functionality was added or removed.