Remove null mask and null count from column_view constructors#13311
Remove null mask and null count from column_view constructors#13311rapids-bot[bot] merged 7 commits intorapidsai:branch-23.06from
Conversation
|
@etseidl I'd like to make sure you are aware of this work. Would you please let me know if you are using |
|
To be clear, @etseidl this particular PR won't affect anything major regarding the mutable column view. The problematic case will be in a subsequent PR (related to this overall project). The relevant change will affect the following current behavior:
Currently, the creation of the mutable view (step 2) unsets the null count in the column, so the next time that the column's null count is queried it is recomputed based on the mask. In the future, that lazy computation of the count will be removed, so the user will be required to set the null count as part of step 3 (setting the mask alone will be insufficient). |
|
/merge |
…13341) Remove the default parameters for null-mask and null-count from `cudf::column` constructors and `set_null_mask` member functions. Reference #13311 Authors: - David Wendt (https://github.com/davidwendt) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Jason Lowe (https://github.com/jlowe) - GALI PREM SAGAR (https://github.com/galipremsagar) - Vyas Ramasubramani (https://github.com/vyasr) - MithunR (https://github.com/mythrocks) URL: #13341
Description
This is a breaking change that removes default values. Removing the default null count value of
UNKNOWN_NULL_COUNTis necessary since we are removingUNKNOWN_NULL_COUNTaltogether. A potential alternative was setting the default to 0, which would correspond to a default null mask ofnullptr(the current default). However, that change is potentially more dangerous if callers were previously setting the null mask to something other thannullptrwithout setting the null count and relying on the behavior ofUNKNOWN_NULL_COUNT. Removing the default parameter altogether is therefore the safer option here.Contributes to #11968.
Checklist