Skip to content

Peers for the peer god#6526

Merged
bcook-r7 merged 10 commits into
rapid7:masterfrom
jlee-r7:peers-for-the-peer-god
Feb 15, 2016
Merged

Peers for the peer god#6526
bcook-r7 merged 10 commits into
rapid7:masterfrom
jlee-r7:peers-for-the-peer-god

Conversation

@jlee-r7

@jlee-r7 jlee-r7 commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

Get rid of a ton of copy pasta.

Verification

  • Run a scanner module that uses TCP
  • Run a non-scanner aux module that uses TCP
  • Run an exploit that uses TCP
    • Also do check
  • Verify no double-printing of the target host

@bcook-r7

bcook-r7 commented Feb 9, 2016

Copy link
Copy Markdown
Contributor

even more?

git grep "\"#{peer} - "|wc -l
     501

@void-in

void-in commented Feb 9, 2016

Copy link
Copy Markdown
Contributor

@bcook-r7 Shouldn't this #{peer} be always available in the modules but not def peer?

@bcook-r7

Copy link
Copy Markdown
Contributor

OK, I see. Looks like this needs updating now.

@bcook-r7 bcook-r7 self-assigned this Feb 15, 2016
@bcook-r7 bcook-r7 merged commit 208420d into rapid7:master Feb 15, 2016
@bcook-r7

Copy link
Copy Markdown
Contributor

OK, landed - whew!

@bcook-r7

Copy link
Copy Markdown
Contributor

the master/spec god was angry with the branch/peer god - fix for that forthcoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants