Clean out unless not#11107
Merged
Merged
Conversation
bwatters-r7
commented
Dec 11, 2018
wvu
reviewed
Dec 12, 2018
wvu
added a commit
that referenced
this pull request
Dec 12, 2018
msjenkins-r7
pushed a commit
that referenced
this pull request
Dec 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came from a @bcook calling me out while whining publicly about
unless notThis PR removes the instances where the double-negative were used, including an entire function hat was copied over from a copy/pasta move.
Verification