Add missing aes and sha2 ISA target for armv8#3780
Closed
Conversation
lieser
commented
Oct 27, 2023
| @@ -57,7 +57,7 @@ BOTAN_FUNC_ISA_INLINE("+crypto") void dec_last(uint8x16_t& B, uint8x16_t K, uint | |||
| B = veorq_u8(vaesdq_u8(B, K), K2); | |||
Collaborator
Author
There was a problem hiding this comment.
Unclear to me why aes ISA is not needed for this function.
Collaborator
Author
|
The change causes problem for GCC (
Before I do more work on this, is the fix even going in the right direction? |
Collaborator
|
It seems that the comma-notation does not work with gcc. Instead, you'd have to specify |
reneme
added a commit
to Rohde-Schwarz/botan
that referenced
this pull request
Mar 5, 2024
This is a follow up for randombit#3780 that fixes the ISA issues for both clang (for Android NDK) and gcc. Co-Authored-By: Philippe Lieser <philippe.lieser@rohde-schwarz.com>
reneme
added a commit
to Rohde-Schwarz/botan
that referenced
this pull request
Mar 6, 2024
This is a follow up for randombit#3780 that fixes the ISA issues for both clang (for Android NDK) and gcc. Co-Authored-By: Philippe Lieser <philippe.lieser@rohde-schwarz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the armv8 amalgamation build using the clang compiler from the Android NDK r26.
Fixes #3774.