Conversation
|
Can we get a merge please? 🙏 Ty 🙂 |
|
+1 |
|
I quote @ekvedaras Can we get a merge please? 🙏 Ty 🙂 |
|
@ramsey Do you have some time to have a look a rerun ci and maybe make a new version if this PR is fine? |
|
I don't know how to force the CI to re-run. The GitHub UI is no longer giving me the button to approve the CI workflow, which is very odd. It also seems there's another problem with allowing brick/math 0.12 and 0.13, as detailed in #586 and #588, and these changes require a BC break in ramsey/uuid. I'm not sure how to proceed. It appears that, in order to upgrade to brick/math 0.12 and 0.13, I'll need to introduce a BC break to ramsey/uuid. |
|
Closeing and reopening the PR will re-run the Ci in most cases.Am 25.05.2025 um 17:58 schrieb Ben Ramsey ***@***.***>:ramsey left a comment (ramsey/uuid#589)
I don't know how to force the CI to re-run. The GitHub UI is no longer giving me the button to approve the CI workflow, which is very odd.
It also seems there's another problem with allowing brick/math 0.12 and 0.13, as detailed in #586 and #588, and these changes require a BC break in ramsey/uuid.
I'm not sure how to proceed. It appears that, in order to upgrade to brick/math 0.12 and 0.13, I'll need to introduce a BC break to ramsey/uuid.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
@kontoulis, you're aware that ramsey/identifier doesn't have any tagged releases yet, right? 😉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #589 +/- ##
=========================================
Coverage 95.16% 95.16%
Complexity 584 584
=========================================
Files 70 70
Lines 1840 1840
=========================================
Hits 1751 1751
Misses 89 89 |
|
@ramsey ofc, but I am looking forward to use that when released instead of alternatives 🙂 |
I need to get back to developing it. Being laid off, searching for a job, and then starting a new job really put a damper on my open source work, but I'm slowly getting back into it. |
|
After further inspection, it looks like my use of a custom See my comment here: #588 (comment) |
Description
This PR changes the composer.json file in order to allow the installation of this package alongside the new 0.13 release of the brick/math library. I believe that the UUID library is not affected by the breaking changes that are documented for the 0.13 release.
Motivation and context
A new version of the brick/math library has been released and development will continue on that branch.
How has this been tested?
I ran the PHPUnit tests. The existing tests should cover the integration of the library well, so no new tests have been added.
Types of changes
PR checklist