Skip to content

Allow brick/math 0.13#589

Merged
ramsey merged 3 commits intoramsey:4.xfrom
derrabus:bump/math
Jun 1, 2025
Merged

Allow brick/math 0.13#589
ramsey merged 3 commits intoramsey:4.xfrom
derrabus:bump/math

Conversation

@derrabus
Copy link
Copy Markdown
Contributor

@derrabus derrabus commented Mar 4, 2025

Description

This PR changes the composer.json file in order to allow the installation of this package alongside the new 0.13 release of the brick/math library. I believe that the UUID library is not affected by the breaking changes that are documented for the 0.13 release.

Motivation and context

A new version of the brick/math library has been released and development will continue on that branch.

How has this been tested?

I ran the PHPUnit tests. The existing tests should cover the integration of the library well, so no new tests have been added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@derrabus derrabus requested a review from ramsey as a code owner March 4, 2025 08:56
@ekvedaras
Copy link
Copy Markdown

Can we get a merge please? 🙏 Ty 🙂

@kontoulis
Copy link
Copy Markdown

kontoulis commented Mar 18, 2025

+1
Right now it is not possible to use this alongside https://github.com/ramsey/identifier due to this dependency constraint.
I understand that identifier would be a replacement, but in my case for example I just need to work with snowflakes without touching the rest of the system which uses uuid.

@derrabus derrabus mentioned this pull request Mar 26, 2025
7 tasks
@Jean-Gian
Copy link
Copy Markdown

I quote @ekvedaras

Can we get a merge please? 🙏 Ty 🙂

@Chris53897
Copy link
Copy Markdown
Contributor

@ramsey Do you have some time to have a look a rerun ci and maybe make a new version if this PR is fine?

@ramsey
Copy link
Copy Markdown
Owner

ramsey commented May 25, 2025

I don't know how to force the CI to re-run. The GitHub UI is no longer giving me the button to approve the CI workflow, which is very odd.

It also seems there's another problem with allowing brick/math 0.12 and 0.13, as detailed in #586 and #588, and these changes require a BC break in ramsey/uuid.

I'm not sure how to proceed. It appears that, in order to upgrade to brick/math 0.12 and 0.13, I'll need to introduce a BC break to ramsey/uuid.

@Chris53897
Copy link
Copy Markdown
Contributor

Chris53897 commented May 25, 2025 via email

@ramsey
Copy link
Copy Markdown
Owner

ramsey commented May 26, 2025

I understand that identifier would be a replacement, but in my case for example I just need to work with snowflakes without touching the rest of the system which uses uuid.

@kontoulis, you're aware that ramsey/identifier doesn't have any tagged releases yet, right? 😉

@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (c72360e) to head (bbad2a2).
⚠️ Report is 45 commits behind head on 4.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                4.x     #589   +/-   ##
=========================================
  Coverage     95.16%   95.16%           
  Complexity      584      584           
=========================================
  Files            70       70           
  Lines          1840     1840           
=========================================
  Hits           1751     1751           
  Misses           89       89           

@kontoulis
Copy link
Copy Markdown

@ramsey ofc, but I am looking forward to use that when released instead of alternatives 🙂

@ramsey
Copy link
Copy Markdown
Owner

ramsey commented May 27, 2025

I am looking forward to use that when released instead of alternatives 🙂

I need to get back to developing it. Being laid off, searching for a job, and then starting a new job really put a damper on my open source work, but I'm slowly getting back into it.

@ramsey
Copy link
Copy Markdown
Owner

ramsey commented Jun 1, 2025

After further inspection, it looks like my use of a custom RoundingMode that performs a translation with brick/math's RoundingMode was actually very beneficial.

See my comment here: #588 (comment)

@ramsey ramsey merged commit bbad2a2 into ramsey:4.x Jun 1, 2025
29 of 31 checks passed
@derrabus derrabus deleted the bump/math branch June 1, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants