Multiway match typechecking and translation for pattern guards#2
Merged
rajgodse merged 15 commits intomultiway-match-parsingfrom Aug 2, 2023
Merged
Multiway match typechecking and translation for pattern guards#2rajgodse merged 15 commits intomultiway-match-parsingfrom
rajgodse merged 15 commits intomultiway-match-parsingfrom
Conversation
Collaborator
ncik-roberts
left a comment
There was a problem hiding this comment.
The translcore changes are trickier than I thought, but they still seem fine. I left a few mostly-minor comments.
e9f2f13 to
afa084b
Compare
8e2d188 to
92d3138
Compare
Owner
Author
|
As discussed, rebased onto test changes in other PRs to consolidate tests before restructuring and splitting test cases into different test files. |
afa084b to
7e4b140
Compare
4a392f5 to
4e9a6c1
Compare
Owner
Author
|
Rebase onto new parsing |
Collaborator
ncik-roberts
left a comment
There was a problem hiding this comment.
A few fairly minor suggestions.
4e9a6c1 to
bc3dd1b
Compare
e3d7c76 to
4e22f63
Compare
ncik-roberts
approved these changes
Aug 2, 2023
Co-authored-by: Nick Roberts <nroberts02@gmail.com>
bc3dd1b to
3f8864d
Compare
rajgodse
added a commit
that referenced
this pull request
Aug 2, 2023
* multiway typechecking and translation * update jane test output * self-review: format and style in translcore * more translcore/typedtree cleanup * expose value `is_guarded_rhs` * fix typedtree printer * make discussed changes to ocamldoc * format: remove unnecessary parens in pattern Co-authored-by: Nick Roberts <nroberts02@gmail.com> * improve parmatch variable naming * explain [exp_attributes] and [exp_extra] weirdness * improve translcore [event_function*] naming * inlined transl_body in transl_rhs * rename pats_exp... to use "rhs" naming * added test for guarded value/exception or-patterns * address ocamldoc CRs --------- Co-authored-by: Nick Roberts <nroberts02@gmail.com>
rajgodse
added a commit
that referenced
this pull request
Aug 3, 2023
Multiway match typechecking and translation for pattern guards (#2) * multiway typechecking and translation * update jane test output * self-review: format and style in translcore * more translcore/typedtree cleanup * expose value `is_guarded_rhs` * fix typedtree printer * make discussed changes to ocamldoc * format: remove unnecessary parens in pattern * improve parmatch variable naming * explain [exp_attributes] and [exp_extra] weirdness * improve translcore [event_function*] naming * inlined transl_body in transl_rhs * rename pats_exp... to use "rhs" naming * added test for guarded value/exception or-patterns * address ocamldoc CRs --------- Co-authored-by: Nick Roberts <nroberts02@gmail.com>
rajgodse
added a commit
that referenced
this pull request
Aug 18, 2023
Multiway match typechecking and translation for pattern guards (#2) * multiway typechecking and translation * update jane test output * self-review: format and style in translcore * more translcore/typedtree cleanup * expose value `is_guarded_rhs` * fix typedtree printer * make discussed changes to ocamldoc * format: remove unnecessary parens in pattern * improve parmatch variable naming * explain [exp_attributes] and [exp_extra] weirdness * improve translcore [event_function*] naming * inlined transl_body in transl_rhs * rename pats_exp... to use "rhs" naming * added test for guarded value/exception or-patterns * address ocamldoc CRs --------- Co-authored-by: Nick Roberts <nroberts02@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements typechecking and translation for pattern guards.
The changes are mostly the straightforward generalization of the single case pattern guard construct.
The main complexity comes from changes related to the restructuring of
Typedtree.case, whose fieldc_rhsused to be of typeexpression, but is now of typecase_rhs, in conjunction with the way that multiway pattern guards change the notion of the rhs of a case.The changes in ocamldoc are type-directed, but it is not apparent that they exhibit the intended behavior. It is worth trying to figure out the intended behavior of the modified functions through review.