Render control-socket injected messages in TUI#5
Merged
Conversation
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 623d0e6de4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
rajeshgoli
added a commit
that referenced
this pull request
Mar 5, 2026
* Add interactive control socket with idempotent request routing * Handle control clients concurrently with capped request reads * Serialize dedupe checks to enforce request idempotency * Refuse live control socket paths unless stale * Bound control worker fanout and request id size * Render control-socket submit_message in TUI * Preserve literal control input semantics and harden socket cleanup
rajeshgoli
added a commit
that referenced
this pull request
Mar 25, 2026
* Add interactive control socket with idempotent request routing * Handle control clients concurrently with capped request reads * Serialize dedupe checks to enforce request idempotency * Refuse live control socket paths unless stale * Bound control worker fanout and request id size * Render control-socket submit_message in TUI * Preserve literal control input semantics and harden socket cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submit_message(when no thread override is provided) through a dedicated app event that uses ChatWidget message submissionthread_idsubmissions on the direct op path and update control-socket test expectationsWhy
Programmatic control submissions were accepted and processed, but injected user text was not visible in the TUI transcript while attached via tmux.
Testing