Check for duplicate content in relevant section when inserting into files#735
Merged
Merged
Conversation
Member
|
I'll have to revert this PR since it changes the behavior when the regexp contains capture. |
rafaelfranca
added a commit
that referenced
this pull request
Jan 4, 2022
This reverts commit 0d3a1dd, reversing changes made to ae18824. This breaks case when the regular expression passed to after and before contains capture. Since `String#split` returns the captures inside the array we can't know with the current implementation what is the before and after the regular expression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some unexpected behavior today with
insert_into_file. I was trying to insert, null: falseinto a migration after some text, but nothing happened.This does nothing because
, null: falseexists in the file (anywhere).Using
after:I would expectinsert_into_fileto only care if the string exists after the matching line, not before it.This PR would change the behavior to only look through the before or after portions of the file content to make it more intuitive.