Indent multiline messages in say_status#714
Merged
rafaelfranca merged 1 commit intoJun 2, 2021
Merged
Conversation
This prevents multiline status messages from breaking the left margin.
As an example, before this commit:
```
status1 single line
status2 multiline line 1
multiline line 2
multiline line 3
status3 multiline indent 0
multiline indent 2
multiline indent 4
status4 single line
```
And after this commit:
```
status1 single line
status2 multiline line 1
multiline line 2
multiline line 3
status3 multiline indent 0
multiline indent 2
multiline indent 4
status4 single line
```
a546e93 to
3343846
Compare
|
@rafaelfranca any chance we can merge this one? |
|
I like this change but it might be breaking behavior since existing usage may be compensating for this by adding more spaces. @rafaelfranca is this something we should leave for a major version bump? Or add a flag for this behavior as an argument? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents multiline status messages from breaking the left margin.
As an example, before this commit:
And after this commit:
Closes rails/rails#38387.