Skip to content

Improve the output log for route action with many lines:#38387

Closed
roramirez wants to merge 1 commit into
rails:masterfrom
roramirez:better-output-log-routes
Closed

Improve the output log for route action with many lines:#38387
roramirez wants to merge 1 commit into
rails:masterfrom
roramirez:better-output-log-routes

Conversation

@roramirez

@roramirez roramirez commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Sumary

This change add indent the lines to improve the read in route section in the console log.

Output before this change


$ rails g controller myspace/other index show
      create  app/controllers/myspace/other_controller.rb
       route  namespace :myspace do
  get 'other/index'
  get 'other/show'
end
      invoke  erb
       exist    app/views/myspace/other
   identical    app/views/myspace/other/index.html.erb
   identical    app/views/myspace/other/show.html.erb
      invoke  test_unit
      create    test/controllers/myspace/other_controller_test.rb
      invoke  helper
      create    app/helpers/myspace/other_helper.rb
      invoke    test_unit
      invoke  assets
      invoke    scss
   identical      app/assets/stylesheets/myspace/other.scss

After this change

$ rails g controller myspace/other index show
      create  app/controllers/myspace/other_controller.rb
       route  namespace :myspace do
                get 'other/index'
                get 'other/show'
              end
      invoke  erb
      create    app/views/myspace/other
      create    app/views/myspace/other/index.html.erb
      create    app/views/myspace/other/show.html.erb
      invoke  test_unit
      create    test/controllers/myspace/other_controller_test.rb
      invoke  helper
      create    app/helpers/myspace/other_helper.rb
      invoke    test_unit
      invoke  assets
      invoke    scss
      create      app/assets/stylesheets/myspace/other.scss

@roramirez
Improve the output log for route action with many lines:
6cd0cf9 
This change add indent the lines to improve the read in route section
in the console log.
@rails-bot rails-bot Bot added the railties label Feb 5, 2020
@roramirez roramirez force-pushed the better-output-log-routes branch from db5e3d3 to 6cd0cf9 Compare February 5, 2020 04:42
@jonathanhefner jonathanhefner mentioned this pull request Feb 21, 2020
Merged
@jonathanhefner

jonathanhefner commented Feb 21, 2020

Copy link
Copy Markdown
Member

Thank you for submitting this PR! I felt like this change should be upstreamed to Thor though, so I submitted rails/thor#714. If it is merged, it will fix this issue.

@roramirez

roramirez commented Feb 22, 2020

Copy link
Copy Markdown
Contributor Author

Nice @jonathanhefner . That's is better solution!. I think we'll need to keep this PR open until you change is merge into the Thor to help to reminder us match the version of thor in railties/railties.gemspec

@rails-bot

rails-bot Bot commented May 22, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot Bot added the stale label May 22, 2020
@roramirez

roramirez commented May 22, 2020

Copy link
Copy Markdown
Contributor Author

Hey, until moment think we'll need to keep open this PR. The PR into Thor isn't merge get so the issue still present, what do you think @jonathanhefner ?

@rails-bot rails-bot Bot removed the stale label May 22, 2020
@rails-bot

rails-bot Bot commented Aug 20, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot Bot added the stale label Aug 20, 2020
@roramirez

roramirez commented Aug 20, 2020

Copy link
Copy Markdown
Contributor Author

Keep it opens ;)

@rails-bot rails-bot Bot removed the stale label Aug 20, 2020
@jonathanhefner jonathanhefner mentioned this pull request Sep 3, 2020
Closed
@rails-bot

rails-bot Bot commented Nov 18, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot Bot added the stale label Nov 18, 2020
@rails-bot rails-bot Bot closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

railties stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roramirez @jonathanhefner