Ensure precompile setting from app is applied to rake task.#35
Merged
brandon-beacher merged 0 commit intorails:masterfrom Jan 13, 2013
Merged
Ensure precompile setting from app is applied to rake task.#35brandon-beacher merged 0 commit intorails:masterfrom
brandon-beacher merged 0 commit intorails:masterfrom
Conversation
Member
|
/cc @josh |
Contributor
|
Is there anyway to write a test for this? |
Author
|
Yep - needs a test - I'll add one. |
Author
|
Ok after writing the tests I think there is a cleaner, more consistent way to do this. It has a prerequisite of sstephenson/sprockets#404 This allows the rake task to set Now to consider how to test this in sprockets-rails! |
Author
|
Closed in favor of a better solution here: #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK - taking another swing at this with a different approach.
I was not able to use the precompile setting to solve the situation described here:
#34
This is due to the details below:
load_tasksprior to the app's configure block.With this change, loose assets in lib or vendor from a legacy gem will now be picked up if they are explicitly specified in the precompile setting.